🐛 Source Insightly: Fix state date conversion bug #19356

henriblancke · 2022-11-11T15:17:29Z

What

Pendulum throws an exception when parsing a datetime.

How

Check if stream state has cursor_field as datetime or string before converting it.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Screenshot of output from `./gradlew :airbyte-integrations:connectors:source-insightly:integrationTest`

Acceptance

Put your acceptance tests output here.

Signed-off-by: Henri Blancke <blanckehenri@gmail.com>

vincentkoc · 2022-11-13T12:02:54Z

@henriblancke thanks for your contribution. I'm one of the Airbyte maintainers and will take a look and review your contribution.

vincentkoc

I'll review the test results and get back to you

Signed-off-by: Henri Blancke <blanckehenri@gmail.com>

henriblancke · 2022-11-15T16:27:15Z

@koconder thanks for taking a look, looks like I was missing pendulum as dependency. I've added it in the last commit and tests seem to pass for me locally:

vincentkoc · 2022-11-15T19:17:02Z

@henriblancke makes sense, ill re-run the test

vincentkoc · 2022-11-15T19:17:08Z

/test connector=connectors/source-insightly

🕑 connectors/source-insightly https://github.com/airbytehq/airbyte/actions/runs/3473467919
✅ connectors/source-insightly https://github.com/airbytehq/airbyte/actions/runs/3473467919
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_insightly/__init__.py       2      0   100%
source_insightly/source.py       214     46    79%
--------------------------------------------------
TOTAL                            216     46    79%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              394    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 293, 331-348, 357-365, 369-374, 380, 413-418, 456-463, 506-508, 511, 576-584, 596-599, 604, 660-661, 667, 670, 706-716, 729-754
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1557    349    78%

Build Passed

Test summary info:

All Passed

vincentkoc

LGTM! Thanks @henriblancke

vincentkoc · 2022-11-15T21:44:49Z

/publish connector=connectors/source-insightly

🕑 Publishing the following connectors:
connectors/source-insightly
https://github.com/airbytehq/airbyte/actions/runs/3474383888

Connector	Did it publish?	Were definitions generated?
connectors/source-insightly	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm · 2022-11-22T20:25:27Z

Hello 👋, first thank you for this amazing contribution.

We really appreciate the effort you've made to improve the project.
We ask you patience for the code review. Last month our team was focused on Hacktoberfest event and that probably left some PR without the proper feedback. And this week, due to the Thanksgiving US Holiday, most our team is out of office with their families. Another important piece of information why code won't be merge this week is: as a safety measure the core team has decided to freeze merging code to main branch to keep the release stable. Next week we'll return to you with the proper code review and update the status of your contribution.

If you have any questions feel free to send me a message in Slack!
Thanks!

marcosmarxm · 2022-12-20T19:51:51Z

Hello 👋:skin-tone-2: and thank you for your contribution!

Airbyte has instituted a code freeze between 19 and 30 December, to make sure there are no disruptions during the holidays.
Because of this, reviewing and merging your contribution may take longer than usual.
We apologize for the delay, but we want everyone to have a quiet and happy holiday.

If you have any questions or need further clarification, please don't hesitate to ping via Slack.

henriblancke added 3 commits November 3, 2022 18:33

[FIX] cursor cast

088454f

Signed-off-by: Henri Blancke <blanckehenri@gmail.com>

Merge branch 'master' into insightly-incremental-fix

d540b09

[UPD] bump version

7490353

Signed-off-by: Henri Blancke <blanckehenri@gmail.com>

octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/insightly labels Nov 11, 2022

Merge branch 'master' into insightly-incremental-fix

aeaa5d6

vincentkoc self-assigned this Nov 13, 2022

vincentkoc self-requested a review November 13, 2022 12:03

vincentkoc suggested changes Nov 13, 2022

View reviewed changes

[FIX] add pendulum dependency

986b086

Signed-off-by: Henri Blancke <blanckehenri@gmail.com>

henriblancke requested a review from vincentkoc November 15, 2022 16:43

Merge branch 'master' into insightly-incremental-fix

ea1c288

vincentkoc approved these changes Nov 15, 2022

View reviewed changes

octavia-squidington-iii and others added 2 commits November 15, 2022 22:04

auto-bump connector version

9ae0120

Merge branch 'master' into insightly-incremental-fix

45b7285

sajarin added the bounty-M Maintainer program: claimable medium bounty PR label Nov 18, 2022

vincentkoc and others added 4 commits December 23, 2022 12:08

Merge branch 'master' into insightly-incremental-fix

9b21fb8

Merge branch 'master' into insightly-incremental-fix

60cefe8

Merge branch 'master' into insightly-incremental-fix

15ccf7c

Merge branch 'master' into insightly-incremental-fix

332a147

sajarin merged commit 3c39e0c into airbytehq:master Jan 17, 2023

octavia-squidington-iii mentioned this pull request Jan 24, 2023

Bump Airbyte version from 0.40.28 to 0.40.29 #21767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Insightly: Fix state date conversion bug #19356

🐛 Source Insightly: Fix state date conversion bug #19356

henriblancke commented Nov 11, 2022

vincentkoc commented Nov 13, 2022

vincentkoc left a comment

henriblancke commented Nov 15, 2022

vincentkoc commented Nov 15, 2022

vincentkoc commented Nov 15, 2022 •

edited by github-actions bot

Loading

vincentkoc left a comment

vincentkoc commented Nov 15, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 22, 2022

marcosmarxm commented Dec 20, 2022

🐛 Source Insightly: Fix state date conversion bug #19356

🐛 Source Insightly: Fix state date conversion bug #19356

Conversation

henriblancke commented Nov 11, 2022

What

How

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

vincentkoc commented Nov 13, 2022

vincentkoc left a comment

Choose a reason for hiding this comment

henriblancke commented Nov 15, 2022

vincentkoc commented Nov 15, 2022

vincentkoc commented Nov 15, 2022 • edited by github-actions bot Loading

Build Passed

vincentkoc left a comment

Choose a reason for hiding this comment

vincentkoc commented Nov 15, 2022 • edited by github-actions bot Loading

marcosmarxm commented Nov 22, 2022

marcosmarxm commented Dec 20, 2022

vincentkoc commented Nov 15, 2022 •

edited by github-actions bot

Loading

vincentkoc commented Nov 15, 2022 •

edited by github-actions bot

Loading